Skip to content

✨ CAPI v1beta2 conditions and deprecations for OSC #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ CAPI v1beta2 conditions and deprecations for OSC #2832

wants to merge 1 commit into from
+893 −6

Conversation

@lentzi90
Copy link
Contributor

@lentzi90 lentzi90 commented Nov 12, 2025

What this PR does / why we need it:

Add CAPI v1beta2 conditions for the OpenStackCluster and deprecate error and failure messages as well as the Ready condition. This also adds the status.initialization.provisioned field.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2374

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2025
@netlify
Copy link

netlify bot commented Nov 12, 2025 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit e3305ba
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-openstack/deploys/692021e4cad4740008399f54
😎 Deploy Preview https://deploy-preview-2832--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 12, 2025
@lentzi90
Copy link
Contributor Author

lentzi90 commented Nov 12, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

bnallapeta
bnallapeta reviewed Nov 12, 2025
View reviewed changes
Copy link
Contributor

@bnallapeta bnallapeta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Few observations from my end.

  • No tests added for Conditions in this PR.
  • Unlike OpenStackMachine that has specific Condition type (InstanceReadyCondition, APIServerIngressReadyCondition etc), this one just has the generic ReadyCondition. Should we consider adding specific conditions for OSC too? (network, secgroups, loadbalancer etc).

p.s.: CI is failing for possibly broken links.

@lentzi90
Copy link
Contributor Author

lentzi90 commented Nov 12, 2025

All good points, thank you!
The link check failure is strange... Maybe there was was some temporary issue.
/retest

@lentzi90 lentzi90 force-pushed the lentzi90/capi-v1b2-osc branch from 0ee8d35 to 11fe5f7 Compare November 17, 2025 10:35
@lentzi90 lentzi90 requested a review from bnallapeta November 20, 2025 07:49
@bnallapeta
Copy link
Contributor

bnallapeta commented Nov 20, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2025
@bnallapeta
Copy link
Contributor

bnallapeta commented Nov 20, 2025

@lentzi90 looks good overall. Just one nit: no negative test cases. All of the current ones test happy path. Please consider adding them either in this PR or a future one.

@lentzi90
CAPI v1beta2 conditions and deprecations for OSC
e3305ba 
Add CAPI v1beta2 conditions for the OpenStackCluster and
deprecate error and failure messages as well as the Ready condition.
This also adds the status.initialization.provisioned field.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/capi-v1b2-osc branch from 11fe5f7 to e3305ba Compare November 21, 2025 08:25
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2025
@lentzi90
Copy link
Contributor Author

lentzi90 commented Nov 21, 2025

Good point! I have added some negative tests. PTAL 🙂

@lentzi90
Copy link
Contributor Author

lentzi90 commented Nov 21, 2025

One thing may need clarification...
I put "CAPI v1beta2 conditions" in the title, but we are here using v1beta1 modules still. The point is that we are implementing (more of) the v1beta2 contract. Since we already have the old type of conditions in use in multiple places, I wanted to stick to that for now. We can then switch all places at once to the new types (breaking API change).

@lentzi90
Copy link
Contributor Author

lentzi90 commented Nov 21, 2025

/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@bnallapeta bnallapeta Awaiting requested review from bnallapeta

Assignees

@bnallapeta bnallapeta

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

CAPO Roadmap
Status: Inbox

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CAPI v1beta2 phase 1 (new fields & deprecations): OpenStackCluster: update API contract to support Conditions

3 participants

@lentzi90 @bnallapeta @k8s-ci-robot